fix(doc): problematic polling operation for lro delete #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in the offical guide, the same polling operation is shared by all lro operations, which could cause problems for some emitters since the lro metadata contains value which doesn't fit for lro delete. See Azure/autorest.csharp#4827 This commit will create a separate polling operation which fits lro delete. The same definition is already available in https://github.com/Azure/typespec-azure/blob/955fc9534c2f7153d45c9fbe5743baa0c104d803/packages/samples/specs/data-plane/trait-versioning/main.tsp#L72-L77
archerzz
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
No changes needing a change description found. |
|
You can try these changes here
|
markcowl
approved these changes
Aug 29, 2024
docs/getstarted/azure-core/step06.md
Outdated
| @@ -28,7 +33,7 @@ interface Widgets { | |||
| createOrUpdateWidget is Operations.LongRunningResourceCreateOrUpdate<Widget>; | |||
There was a problem hiding this comment.
@markcowl
Is it OK for us to replace this example with LongRunningResourceCreateOrReplace?
As Azure guideline (DPG)
⛔ DO NOT implement PATCH as an LRO. If LRO update semantics are required, implement it using the LRO POST action pattern .
There was a problem hiding this comment.
I updated according to Weidong's comment. I can roll back to previous comment if needed.
weidongxu-microsoft
approved these changes
Aug 29, 2024
XiaofeiCao
reviewed
Aug 29, 2024
XiaofeiCao
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the offical guide, the same polling operation is shared by all lro operations, which could cause problems for some emitters since the lro metadata contains value which doesn't fit for lro delete. See Azure/autorest.csharp#4827
This commit will create a separate polling operation which fits lro delete. The same definition is already available in
typespec-azure/packages/samples/specs/data-plane/trait-versioning/main.tsp
Lines 72 to 77 in 955fc95